-
-
Notifications
You must be signed in to change notification settings - Fork 667
Move FuncDeclaration.isVirtual to funcsem
#22340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for your pull request and interest in making D better, @elshorbagyx! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#22340" |
|
merge conflicts |
thewilsonator
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise looks good
cf42420 to
8e4fb28
Compare
compiler/src/dmd/frontend.h
Outdated
| CtorDeclaration* syntaxCopy(Dsymbol* s) override; | ||
| const char* kind() const override; | ||
| bool isVirtual() const override; | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove these newlines in this file
4d0e8c3 to
f8aece8
Compare
To break the dependency of
func.donobjc.d