Skip to content

Conversation

@elshorbagyx
Copy link
Contributor

To break the dependency of func.d on objc.d

@elshorbagyx elshorbagyx requested a review from ibuclaw as a code owner January 2, 2026 13:15
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @elshorbagyx! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#22341"

import dmd.visitor;
import dmd.visitor.statement_rewrite_walker;

bool addPostInvariant(FuncDeclaration _this)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these functions are only called from semantic3.d so if you move them there you can make them private.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addPostInvariant is used in expressionsem

@thewilsonator thewilsonator merged commit 94a96f0 into dlang:master Jan 2, 2026
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants