Skip to content

Backport some more PR's for DLL"s#22572

Merged
thewilsonator merged 2 commits intodlang:stablefrom
rikkimax:backport/ci2
Feb 14, 2026
Merged

Backport some more PR's for DLL"s#22572
thewilsonator merged 2 commits intodlang:stablefrom
rikkimax:backport/ci2

Conversation

@rikkimax
Copy link
Contributor

Adding a couple more PR's to backport as I'm running into CI on stable timing out.

#22052

#22162

rainers and others added 2 commits February 15, 2026 04:40
…#22052)

tests dllgc and dynamiccast compile both executable and shared library from the same source file, but the DLL with -version=DLL. Both targets have the same intermediate object file which can cause both build and runtime errors when building concurrently.

Solution: generate object files for DLLs to a different directory
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @rikkimax! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "stable + dmd#22572"

@rikkimax
Copy link
Contributor Author

Not as much time shaved off as I'd have liked, but enough that at least it can go green now.

@thewilsonator thewilsonator merged commit 69a04d3 into dlang:stable Feb 14, 2026
78 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants