Do proper construction when initializing __result#22620
Merged
dkorpel merged 1 commit intodlang:masterfrom Feb 23, 2026
Merged
Conversation
Contributor
|
Thanks for your pull request and interest in making D better, @limepoutine! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#22620" |
thewilsonator
approved these changes
Feb 23, 2026
Member
|
@limepoutine seems reasonable. The |
This was referenced Feb 24, 2026
IDONTUSEGH
added a commit
to IDONTUSEGH/dmd
that referenced
this pull request
Mar 5, 2026
)" This reverts commit 5428018.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calling copy constructor is currently done through the side effect of constructing a temporary variable. It's equivalent to constructing
__resultdirectly without jumping through another temporary, so this PR changes returning through__resultto construct it instead of making a temporary. This removes a special case in the backend.This PR is also in high-risk territory because it affects all functions using out contract or
opApply. What's worse, this PR is not easily testable because copy/move-return should behave exactly the same as copy/move-initialization.cc @ibuclaw @kinke
This should fix GDC's bug w.r.t out contract breaking RVO in move-return. Should be fine with LDC at a first glance, but warrants a look.