fix issue #22556 - shared AAs with RefCounted values don't work even after removing shared#22645
Merged
dlang-bot merged 1 commit intodlang:stablefrom Feb 27, 2026
Merged
Conversation
…even after removing shared allow AA.clear with shared values for backward compatibility
Contributor
|
Thanks for your pull request, @rainers! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.
|
ibuclaw
approved these changes
Feb 27, 2026
Contributor
|
If you do a PR to deprecate shared AA's, I can bring it up at the next monthly meeting. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
allow AA.clear with shared values for backward compatibility
Long term, access to shared AAs should be deprecated, there is little safe about that. clear() in the given scenario might be an exception, as it only removes the non-shared part of the AA pointing to the shared values.