Skip to content

dmd: file: Add PROT_READ to mmap protections.#22787

Merged
thewilsonator merged 1 commit intodlang:masterfrom
yelninei:mmap
Mar 23, 2026
Merged

dmd: file: Add PROT_READ to mmap protections.#22787
thewilsonator merged 1 commit intodlang:masterfrom
yelninei:mmap

Conversation

@yelninei
Copy link
Copy Markdown
Contributor

On Hurd missing PROT_READ causes a segmentation fault with a later memcpy to the mmaped memory

As the file is opened with O_RDWR i dont think this should change anything.

I also changed a check for mmap failure to MAP_FAILED

Let me know if I should split that into 2 commit and if the commit message is ok.

@dlang-bot
Copy link
Copy Markdown
Contributor

Thanks for your pull request and interest in making D better, @yelninei! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#22787"

@thewilsonator thewilsonator merged commit 23fa06c into dlang:master Mar 23, 2026
42 checks passed
@yelninei yelninei deleted the mmap branch March 27, 2026 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants