Skip to content

Fix #22813 - Removing __monitor from Object leads to errors#22817

Merged
dkorpel merged 3 commits intodlang:masterfrom
dkorpel:no-monitor-typeinfo-size
Apr 28, 2026
Merged

Fix #22813 - Removing __monitor from Object leads to errors#22817
dkorpel merged 3 commits intodlang:masterfrom
dkorpel:no-monitor-typeinfo-size

Conversation

@dkorpel
Copy link
Copy Markdown
Contributor

@dkorpel dkorpel commented Mar 26, 2026

Closes #22813

Need to check whether LDC and GDC use target.classinfosize

@dlang-bot
Copy link
Copy Markdown
Contributor

Thanks for your pull request and interest in making D better, @dkorpel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

⚠️⚠️⚠️ Warnings ⚠️⚠️⚠️

  • In preparation for migrating from Bugzilla to GitHub Issues, the issue reference syntax has changed. Please add the word "Bugzilla" to issue references. For example, Fix Bugzilla Issue 12345 or Fix Bugzilla 12345.(Reminder: the edit needs to be done in the Git commit message, not the GitHub pull request.)

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#22817"

@thewilsonator
Copy link
Copy Markdown
Contributor

LDC does not.

@thewilsonator
Copy link
Copy Markdown
Contributor

Comment thread compiler/src/dmd/glue/toobj.d Outdated
@dkorpel dkorpel force-pushed the no-monitor-typeinfo-size branch from 4264f07 to ad18595 Compare April 23, 2026 11:53
@thewilsonator
Copy link
Copy Markdown
Contributor

Need to update compilable/b18242.d

// REQUIRED_ARGS: -c
// PERMUTE_ARGS:
module object;

class Object { }

class TypeInfo { }
class TypeInfo_Class : TypeInfo
{
    version(D_LP64) { ubyte[136+24] _x; } else { ubyte[68+20] _x; }
}

class Throwable { }

int _d_run_main()
{
    try { } catch(Throwable e) { return 1; }
    return 0;
}

(why that compilable test defines _d_run_main when it has // REQUIRED_ARGS: -c I'm not sure, but the size calculations for the size of TypeInfo_Class need updating)

Looking good!

@thewilsonator
Copy link
Copy Markdown
Contributor

Ping. Fixed the test, is this good to go now?

@dkorpel dkorpel marked this pull request as ready for review April 28, 2026 21:16
@dkorpel dkorpel requested a review from ibuclaw as a code owner April 28, 2026 21:16
@dkorpel
Copy link
Copy Markdown
Contributor Author

dkorpel commented Apr 28, 2026

Yes, thanks

@dkorpel dkorpel merged commit aeca9a9 into dlang:master Apr 28, 2026
34 of 42 checks passed
@dkorpel dkorpel deleted the no-monitor-typeinfo-size branch April 28, 2026 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Removing __monitor from Object leads to errors

3 participants