Skip to content

Fix #23166 Set sc3.minst to root module#23169

Merged
thewilsonator merged 3 commits into
dlang:masterfrom
gulugulubing:issues23166
May 26, 2026
Merged

Fix #23166 Set sc3.minst to root module#23169
thewilsonator merged 3 commits into
dlang:masterfrom
gulugulubing:issues23166

Conversation

@gulugulubing
Copy link
Copy Markdown
Contributor

This is related to #23166. RTInfoImpl!([32, 9]) is not emitted when codegen, because it is categerized in c module.
And reordering the field may change RTInfoImpl!([32, 9]) to RTInfoImpl!([32, 10]), which accidently is defined in phobos.

@dlang-bot
Copy link
Copy Markdown
Contributor

Thanks for your pull request and interest in making D better, @gulugulubing! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#23169"

Copy link
Copy Markdown
Contributor

@thewilsonator thewilsonator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise looks good

Comment thread compiler/src/dmd/semantic3.d Outdated
Comment thread compiler/src/dmd/semantic3.d Outdated
@thewilsonator thewilsonator merged commit 42e75e5 into dlang:master May 26, 2026
42 of 43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants