remove stink of corruption from scanelf.d#5938
Merged
andralex merged 1 commit intodlang:masterfrom Jul 19, 2016
Merged
Conversation
Member
|
I like this, looking goo.d. |
src/scanelf.d
Outdated
| if (base.length < Elf32_Ehdr.sizeof) | ||
| return corrupt(__LINE__); | ||
|
|
||
| immutable ubyte[4] elf = [0x7F, 'E', 'L', 'F']; // ELF file signature |
Member
There was a problem hiding this comment.
make it static lest you end up initializing it every pass through the function
Contributor
There was a problem hiding this comment.
LDC will emit this into the data segment just as well. No idea about DMD, though.
Member
Author
There was a problem hiding this comment.
DMD makes immutables static anyway.
Member
There was a problem hiding this comment.
Member
|
Please fix the byte[4] |
| if (base.length < Elf32_Ehdr.sizeof) | ||
| return corrupt(__LINE__); | ||
|
|
||
| static immutable ubyte[4] elf = [0x7F, 'E', 'L', 'F']; // ELF file signature |
Member
There was a problem hiding this comment.
Member
|
Auto-merge toggled on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should no longer crash when fed a corrupt object file. Switched to arrays rather than pointer arithmetic. Removed dead code. Removed use of
goto. Simplified error handling.