-
-
Notifications
You must be signed in to change notification settings - Fork 413
RISCV: Add some definitions and vararg supports #3846
Conversation
This is based on RISCV Calling Convention and hints in comments (e.g. elf/elf.h in glibc).
|
Thanks for your pull request and interest in making D better, @Ast-x64! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + druntime#3846" |
ljmf00
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Anyone with experience in the RISC-V ABI to double-check this?
va_list is indeed a |
Yes I'm trying to port LDC to riscv64gc platform. My current draft version shows, |
Based on dlang#3846 and dlang#3854.
This is based on RISCV Calling Convention and hints in comments (e.g.
elf/elf.h in glibc).