Skip to content
This repository was archived by the owner on Oct 12, 2022. It is now read-only.

Conversation

@Ast-x64
Copy link
Contributor

@Ast-x64 Ast-x64 commented Jun 16, 2022

This is based on RISCV Calling Convention and hints in comments (e.g.
elf/elf.h in glibc).

This is based on RISCV Calling Convention and hints in comments (e.g.
	elf/elf.h in glibc).
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @Ast-x64! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + druntime#3846"

Copy link
Member

@ljmf00 ljmf00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Anyone with experience in the RISC-V ABI to double-check this?

@ibuclaw
Copy link
Member

ibuclaw commented Jun 16, 2022

Looks good. Anyone with experience in the RISC-V ABI to double-check this?

va_list is indeed a void* on RISC-V. Can't say much about the other parts of varargs and dwarfeh, other than seem reasonable. I assume this is for the benefit of LDC? (GDC has __builtin_eh_return_data_regno and __builtin_va_arg intrinsics exposed from the backend)

@ljmf00 ljmf00 changed the title RISCV64: Add some definitions and vararg supports RISCV: Add some definitions and vararg supports Jun 16, 2022
@Ast-x64
Copy link
Contributor Author

Ast-x64 commented Jun 17, 2022

I assume this is for the benefit of LDC?

Yes I'm trying to port LDC to riscv64gc platform. My current draft version shows, printf (which uses vararg to pass parameters) is working properly under my tests.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants