Skip to content
This repository was archived by the owner on Oct 12, 2022. It is now read-only.

Conversation

@Ast-x64
Copy link
Contributor

@Ast-x64 Ast-x64 commented Jun 21, 2022

Fixing previous wrong implementation according to RISCV Calling
Convention. Arguments larger than 2*XLEN bits are replaced by the
address, and others with 2*XLEN-bit alignment should be aligned in
register or stack.

Fixing previous wrong implementation according to RISCV Calling
Convention. Arguments larger than 2*XLEN bits are replaced by the
address, and others with 2*XLEN-bit alignment should be aligned in
register or stack.
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @Ast-x64! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + druntime#3854"

@Ast-x64
Copy link
Contributor Author

Ast-x64 commented Jun 21, 2022

This should fix wrong implementation in #3846. Now it is able to fully pass the ldc_cabi test in the LDC forked version of dmd testsuite (which includes many different cases of va_arg tests), using a draft riscv port of LDC.

@dlang-bot dlang-bot merged commit e150cca into dlang:master Jun 21, 2022
Ast-x64 added a commit to Ast-x64/druntime that referenced this pull request Jun 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants