Skip to content
This repository was archived by the owner on Feb 8, 2024. It is now read-only.

Conversation

@Ast-x64
Copy link

@Ast-x64 Ast-x64 commented Jun 28, 2022

Mainly based on dlang#3846 and dlang#3854.

Ast-x64 added 2 commits June 28, 2022 19:27
Implemented according to RISCV Calling Convention.
@kinke
Copy link
Member

kinke commented Jun 28, 2022

Hmm, if the upstream PRs had targeted stable, it would have made it into v1.30 final automatically. - I'm not too keen on cherry-picking non-trivial v2.101 stuff for v1.30 and cause potential merge issues for v2.101 later on.

@Ast-x64
Copy link
Author

Ast-x64 commented Jun 28, 2022

Hmm, if the upstream PRs had targeted stable, it would have made it into v1.30 final automatically. - I'm not too keen on cherry-picking non-trivial v2.101 stuff for v1.30 and cause potential merge issues for v2.101 later on.

Thanks for your reply. I understand your merging consideration. Currently I'm backporting this in order to port LDC to riscv64gc platform, which depends on these modifications. And codes in the second commit here seem to be LDC owned codes (which do not affect upstream dlang/druntime).

@kinke
Copy link
Member

kinke commented Nov 20, 2022

Thanks, I've rebased this locally, after which the 1st commit resulted in a no-op as expected; the 2nd commit is in branch ldc now.

@kinke kinke closed this Nov 20, 2022
kinke added a commit to ldc-developers/ldc that referenced this pull request Nov 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants