Skip to content

Add dub fetch <package>@<version> shortcut#1643

Merged
s-ludwig merged 1 commit intodlang:masterfrom
wilzbach:fetch-version
Feb 13, 2019
Merged

Add dub fetch <package>@<version> shortcut#1643
s-ludwig merged 1 commit intodlang:masterfrom
wilzbach:fetch-version

Conversation

@wilzbach
Copy link
Contributor

@wilzbach wilzbach commented Jan 31, 2019

Follow-up to #1428 (comment)

FWIW the recently added dub add uses =, but as both = and : can't be part
of a valid version we can just support both as valid splitting symbols to avoid any potential confusion.

edit: now changed to @ instead of :

@dlang-bot
Copy link
Collaborator

Thanks for your pull request, @wilzbach!

@s-ludwig
Copy link
Member

: is used as the sub package delimiter, so that may lead to confusion (while I think the set of valid package names is distinct from the set of valid version names). I'd suggest to use the more commonly found @ instead.

@wilzbach wilzbach changed the title Add dub fetch <package>:<version> shortcut Add dub fetch <package>@<version> shortcut Jan 31, 2019
@wilzbach
Copy link
Contributor Author

I'd suggest to use the more commonly found @ instead.

Fair point. Changed to @.

@s-ludwig s-ludwig merged commit 8939b73 into dlang:master Feb 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants