Merged
Conversation
Member
MartinNowak
commented
Apr 28, 2019
MartinNowak
commented
- fix Regression: Range violation #1681 - range violation with empty arg
- add output if package wasn't found online
- add non-interactive mode that doesn't search for online packages
Collaborator
|
Thanks for your pull request, @MartinNowak! |
Member
Author
|
Sorry for craming multiple things into this PR. |
Contributor
|
The fix for #1681 looks good to me. |
thewilsonator
approved these changes
Apr 28, 2019
Member
Author
|
Let me merge the non-controversial stuff before the last commit so I can build a release candidate. |
- useful to build already fetched package - skips online search and interactive fetch dialog
Contributor
|
I don't think it's super controversial. Thanks a lot for this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.