Skip to content

Fixes UUID v7 Method 3 processing for MacOS on arm64#11065

Merged
kinke merged 6 commits into
dlang:stablefrom
denizzzka:uuid_v7_method3_fix_for_mac_arm64
Jul 14, 2026
Merged

Fixes UUID v7 Method 3 processing for MacOS on arm64#11065
kinke merged 6 commits into
dlang:stablefrom
denizzzka:uuid_v7_method3_fix_for_mac_arm64

Conversation

@denizzzka

@denizzzka denizzzka commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Rationale

Discussion:
#10862 (comment)

Pre-review checklist

  • I have performed a self-review of my code.
  • If my PR fixes a bug or introduces a new feature, I have added thorough tests.
    - [ ] If my changes are non-trivial and do not concern a reported issue, I have added a changelog entry.

@denizzzka denizzzka marked this pull request as draft July 13, 2026 08:24
@denizzzka denizzzka force-pushed the uuid_v7_method3_fix_for_mac_arm64 branch from 7b84874 to dd406ca Compare July 13, 2026 08:26
@denizzzka denizzzka force-pushed the uuid_v7_method3_fix_for_mac_arm64 branch 3 times, most recently from 536525f to e536253 Compare July 13, 2026 08:41
Comment thread std/uuid.d Outdated
@kinke

kinke commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

And please target branch stable, to fix this for v2.113 still, where these UUID additions landed.

@denizzzka denizzzka force-pushed the uuid_v7_method3_fix_for_mac_arm64 branch from e536253 to 6847827 Compare July 14, 2026 01:50
@denizzzka denizzzka force-pushed the uuid_v7_method3_fix_for_mac_arm64 branch from 6847827 to ae54d47 Compare July 14, 2026 01:56
@denizzzka denizzzka changed the base branch from master to stable July 14, 2026 01:57
@denizzzka denizzzka marked this pull request as ready for review July 14, 2026 02:47
@denizzzka

Copy link
Copy Markdown
Contributor Author

TODO for next PR:

  • It is need to exclude possibility of ticks overflow: add checked int and check the initial offset value
  • Write a comment about user can't leave this factory on for long because the system wall clocks and monotone clocks will accumulate difference

kinke added a commit to kinke/ldc that referenced this pull request Jul 14, 2026
Comment thread std/uuid.d Outdated
@kinke

kinke commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

LDC CI confirms that the unittests now pass on macOS arm64 too - the 3 hnsecs for the test, converted to ~2.9 hnsecs internally in 24 MHz MonoTime ticks, now make the sub-ms part end up correctly in the 2nd bin (about [2.5, 5) hnsecs, due to the 4096 bins per ms).

kinke added a commit to kinke/ldc that referenced this pull request Jul 14, 2026
@kinke kinke merged commit cbbe086 into dlang:stable Jul 14, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants