Output external adjunct on Manifests #1089
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename IncludeRelevantMetadata() to IncludeRelationsForProjections() and include adjuncts in query
Tests for outputting external adjuncts
p-kaczynski
approved these changes
Jan 23, 2026
Contributor
p-kaczynski
left a comment
p-kaczynski
left a comment
There was a problem hiding this comment.
Looks good, to my best knowledge at least :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1074
Externally hosted adjuncts are now output on single-item and NQ manifests in accordance with rules on #1074
Summary of changes:
IncludeRelevantMetadata()toIncludeRelationsForProjections()and extended to include adjuncts. The latter name seems clearer as adjuncts aren't metadata.ManifestV3Builcerto add adjuncts to relevant canvases.Note
As mentioned in ticket
IncludeRelationsForProjections()uses.Include(a => a.Adjuncts!.Where(adj => adj.ExternalId != null). This is non-functional now but means that when hosted adjuncts are introduced to API they don't prematurely appear in generated Manifest.Note
In the case of
iiifLink = "annotations", some of the provided Adjuncts values are ignored. I will open a further ticket for returning to this as it's low priority.