Merged
Conversation
* origin only in hydra model * also extract props common to Adjunct and Asset (ingesting ,error) to interface and update "clearing" extension method
also minor existing integration test fix
Includes some fixes to bugs found during testing
donaldgray
reviewed
Feb 5, 2026
Contributor
|
LGTM - although I'm not as close to the API's internals as the rest of the team, so it would be good to get their eyes on it. |
JackLewis-digirati
approved these changes
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Impl #1076
POST/PUT Adjunct can now - instead of
ExternalId- provideOriginproperty. If that happens, we set new propertyIngestingtotrueandErrorto(empty string), and a request is put to a new SQS queue.Warning
Requires new queue (
-adjuncts) andAWS__SQS__AdjunctQueueNamesetting for API to work correctly - otherwiseThrowIfNulltriggers forOrigin-having adjuncts.