Refresh OrchestrationImage info.json create#1119
Merged
donaldgray merged 1 commit intodevelopfrom Mar 2, 2026
Merged
Conversation
Avoids issues where stale OrchestrationImage can be used to create info.json. We cache info.json for a long time, so created with stale data that can hang around. If info.json is missing it means the image new, or it has recently been updated and cleanup-handler has removed.
griffri
approved these changes
Mar 2, 2026
Contributor
griffri
left a comment
griffri
left a comment
There was a problem hiding this comment.
LGTM - would be good to have the others' eyes on it too
JackLewis-digirati
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoids issues where stale OrchestrationImage can be used to create info.json. We cache info.json for a long time, so created with stale data that can hang around. If info.json is missing it means the image new, or it has recently been updated and cleanup-handler has removed.
This looks like more changes than it actually is, summary:
IOrchestratorAssetRepository : IAssetRepository, which adds anoCacheoverload ofGetAsset()DapperAssetRepositoryinherits from above, so had to move into Orchestrator (this should have been done a while ago).MemoryAssetTracker.RefreshCachedAssetto call new overload withtrue(ie get a fresh asset)AssetIdrather thanOrchestrationAssetwhen building info.json.