Publish notification AdjunctBatch completion#1172
Merged
donaldgray merged 3 commits intodevelopfrom Apr 15, 2026
Merged
Conversation
2 tasks
JackLewis-digirati
approved these changes
Apr 15, 2026
1ed7a19 to
c96e158
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Resolves #1163
Update API and Engine to publish AdjunctBatch completion topic. This will happen whether the batch was successful or contains errors.
Main areas of change were:
CreateAdjunctBatchHandlerwill raise if AdjunctBatch.Finished has a valueEngineAssetRepositorywill raise if just-saved adjunct means batch is completed.Other areas / details:
IBatchCompletedNotificationSendertakes a singleIDeliverableBatchto share logic with Batch and AdjunctBatch.ITopicPublisherhas and adjunct and asset "publish batch completed" overload but internally they share implementation.EngineAssetRepositoryto share more batch completion code, leveraging various shared interfacesIDeliverableBatchItem,IDeliverableandIDeliverableBatchInfrastructure Changes
Note
This PR requires infrastructure changes.
AdjunctBatchis completed. If missing a warning will be logged.Configuration Changes
Note
This PR introduces configuration changes.
AWS:SNS:AdjunctBatchCompletedTopicArnnullAWS:SNS:AdjunctBatchCompletedTopicArnnull