Skip to content

Publish notification AdjunctBatch completion#1172

Merged
donaldgray merged 3 commits intodevelopfrom
feature/adjunct_batch_completion
Apr 15, 2026
Merged

Publish notification AdjunctBatch completion#1172
donaldgray merged 3 commits intodevelopfrom
feature/adjunct_batch_completion

Conversation

@donaldgray
Copy link
Copy Markdown
Member

What does this change?

Resolves #1163

Update API and Engine to publish AdjunctBatch completion topic. This will happen whether the batch was successful or contains errors.

Main areas of change were:

  • API - CreateAdjunctBatchHandler will raise if AdjunctBatch.Finished has a value
  • Engine - EngineAssetRepository will raise if just-saved adjunct means batch is completed.

Other areas / details:

  • IBatchCompletedNotificationSender takes a single IDeliverableBatch to share logic with Batch and AdjunctBatch.
  • ITopicPublisher has and adjunct and asset "publish batch completed" overload but internally they share implementation.
  • Refactored EngineAssetRepository to share more batch completion code, leveraging various shared interfaces IDeliverableBatchItem, IDeliverable and IDeliverableBatch

Infrastructure Changes

Note

This PR requires infrastructure changes.

  • Required: N/A
  • Optional: AdjunctBatch completion SNS topic. If present API or Engine will publish a notification when an AdjunctBatch is completed. If missing a warning will be logged.

Configuration Changes

Note

This PR introduces configuration changes.

Service AppSetting Required? Description Default
Engine AWS:SNS:AdjunctBatchCompletedTopicArn N ARN for AdjunctBatch Completion SNS topic null
API AWS:SNS:AdjunctBatchCompletedTopicArn N ARN for AdjunctBatch Completion SNS topic null

@donaldgray donaldgray requested a review from a team as a code owner April 14, 2026 13:47
@donaldgray donaldgray linked an issue Apr 15, 2026 that may be closed by this pull request
2 tasks
Base automatically changed from feature/create_adjunctbatch to develop April 15, 2026 15:41
@donaldgray donaldgray force-pushed the feature/adjunct_batch_completion branch from 1ed7a19 to c96e158 Compare April 15, 2026 15:48
@donaldgray donaldgray merged commit 15ddd53 into develop Apr 15, 2026
8 checks passed
@donaldgray donaldgray deleted the feature/adjunct_batch_completion branch April 15, 2026 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AdjunctBatch raises completed notification

2 participants