Add Java primitive wrapper classes - #176
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #176 +/- ##
==========================================
+ Coverage 83.89% 85.35% +1.46%
==========================================
Files 173 181 +8
Lines 12939 15569 +2630
==========================================
+ Hits 10855 13289 +2434
- Misses 2084 2280 +196 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR extends RustJava’s Java runtime library to include Java 1.2-compatible primitive wrapper classes (plus Number) and integrates primitive Class objects used by wrapper TYPE fields, with a broad set of runtime tests validating parsing, formatting, comparisons, and reflection behavior.
Changes:
- Add
java/lang/Numberand implement missing primitive wrapper classes (Boolean,Byte,Short,Long,Float,Double,Character) plus major expansion ofInteger. - Add primitive
Classconstruction and primitive-aware logic forClass.getName,Class.isPrimitive, andClass.isAssignableFrom. - Add comprehensive async integration tests covering wrapper APIs, boundaries, errors, GC stability of
TYPE, andNumber/Comparablemetadata.
Reviewed changes
Copilot reviewed 25 out of 25 changed files in this pull request and generated 14 comments.
Show a summary per file
| File | Description |
|---|---|
| jvm/src/runtime/java_lang_class.rs | Adds primitive Class construction and stricter name decoding used by runtime java/lang/Class. |
| java_runtime/src/loader.rs | Registers new runtime class prototypes so wrappers/Number resolve at runtime. |
| java_runtime/src/classes/java/lang.rs | Wires new wrapper modules into the java.lang runtime module exports. |
| java_runtime/src/classes/java/lang/number.rs | Adds abstract Number base class with concrete byteValue/shortValue and abstract numeric conversions. |
| java_runtime/src/classes/java/lang/integer.rs | Expands Integer to a Java-1.2-like API surface (parsing, decode, getInteger, formatting, comparisons, TYPE/MIN/MAX). |
| java_runtime/src/classes/java/lang/boolean.rs | Implements Boolean wrapper (TRUE/FALSE/TYPE, parsing/valueOf, getBoolean). |
| java_runtime/src/classes/java/lang/byte.rs | Implements Byte wrapper APIs including parsing/decoding, constants, comparisons, and TYPE. |
| java_runtime/src/classes/java/lang/short.rs | Implements Short wrapper APIs including parsing/decoding, constants, comparisons, and TYPE. |
| java_runtime/src/classes/java/lang/long.rs | Implements Long wrapper APIs including parse/decode/getLong, formatting helpers, comparisons, and TYPE. |
| java_runtime/src/classes/java/lang/float.rs | Implements Float wrapper APIs including parse/valueOf, bit conversions, constants, comparisons, and TYPE. |
| java_runtime/src/classes/java/lang/double.rs | Implements Double wrapper APIs including parse/valueOf, bit conversions, constants, comparisons, and TYPE. |
| java_runtime/src/classes/java/lang/character.rs | Implements Character wrapper APIs including classification, case mapping, digit/numeric helpers, constants, comparisons, and TYPE. |
| java_runtime/src/classes/java/lang/comparable.rs | Defines Comparable.compareTo(Object) as an abstract method and corrects interface access flags. |
| java_runtime/src/classes/java/lang/class.rs | Adds Class.isPrimitive, primitive-aware isAssignableFrom, and null-check for forName; uses JavaLangClass::name. |
| java_runtime/tests/classes/java/lang/mod.rs | Includes new wrapper/Number test modules in the test suite. |
| java_runtime/tests/classes/java/lang/test_class.rs | Adds tests for primitive Class objects, primitive rejection in forName, assignability rules, and GC stability of TYPE. |
| java_runtime/tests/classes/java/lang/test_number.rs | Verifies Number is abstract and wrappers implement Number/Comparable/Serializable as expected. |
| java_runtime/tests/classes/java/lang/test_integer.rs | Expands coverage for Integer APIs (radix parsing, decode, formatting, compareTo errors, getInteger defaults, TYPE stability). |
| java_runtime/tests/classes/java/lang/test_boolean.rs | Adds coverage for Boolean parsing, constants, getBoolean, and Java 1.2 API exclusions. |
| java_runtime/tests/classes/java/lang/test_byte.rs | Adds coverage for Byte parsing/decoding, overflow errors, comparisons, and TYPE. |
| java_runtime/tests/classes/java/lang/test_short.rs | Adds coverage for Short parsing/decoding, overflow errors, comparisons, and TYPE. |
| java_runtime/tests/classes/java/lang/test_long.rs | Adds coverage for Long parsing/decoding/getLong, formatting, overflow errors, comparisons, and TYPE. |
| java_runtime/tests/classes/java/lang/test_float.rs | Adds coverage for Float parsing, formatting, NaN/Infinity, bits conversions, comparisons, constants, and TYPE. |
| java_runtime/tests/classes/java/lang/test_double.rs | Adds coverage for Double parsing, formatting, NaN/Infinity, bits conversions, comparisons, constants, and TYPE. |
| java_runtime/tests/classes/java/lang/test_character.rs | Adds coverage for Character constants, classification, radix helpers, surrogate handling, and compareTo error behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d80e4cc9fe
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Judged the two remaining remote branches on the fork: - dependabot/cargo/tracing-attributes-0.1.31: deleted. PR #4 (fa92ef9) removed the tracing-attributes direct dependency outright, so the branch patches a Cargo.toml line that no longer exists. - wie-ktf-hardening: preserved. 8 of its 12 commits are already in upstream/main via squash merges (dlunch#174 dlunch#175 dlunch#176 dlunch#177 dlunch#180 dlunch#182); git cherry missed this because origin/main trails upstream/main by 20 commits. 4 commits carry residual value. No code changes. Co-authored-by: jun0 <junyoung.choi.a@miraeasset.com> Co-authored-by: Claude <noreply@anthropic.com>
…am-sync-s1-tracing-cut-1f356ae] * Bump bytemuck from 1.25.0 to 1.25.1 (dlunch#173) Bumps [bytemuck](https://github.com/Lokathor/bytemuck) from 1.25.0 to 1.25.1. - [Changelog](https://github.com/Lokathor/bytemuck/blob/main/changelog.md) - [Commits](Lokathor/bytemuck@v1.25.0...v1.25.1) --- updated-dependencies: - dependency-name: bytemuck dependency-version: 1.25.1 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Replace runtime panics with the matching Java exceptions (dlunch#174) * Replace runtime panics with the matching Java exceptions An unwrap audit found panics reachable from ordinary Java code: - File.length() returns 0 for a missing file; isDirectory/isFile lose their guard-then-unwrap shape - FileImpl (native runtime) maps open/read/write/seek failures to IOError instead of panicking, so FileInputStream and RandomAccessFile guards actually produce FileNotFoundException; FileOutputStream gains the same guard - File I/O operations (read/write/seek/available/length/setLength) throw java.io.IOException on failure via a shared helper - Class.forName resolves the class and throws ClassNotFoundException (new runtime class) instead of panicking on any not-yet-loaded name - StringBuffer.append(char)/append(char[]) keep exact UTF-16 units so unpaired surrogates no longer panic and pairs built char by char survive; String.valueOf(char) builds through [C for the same reason - PrintStream.println(char) replaces an unpaired surrogate with '?' like the JDK charset encoder - ZipFile validates the archive in its constructor and throws java.util.zip.ZipException (new runtime class) for a malformed archive; getInputStream returns null for a missing entry Expected outputs for the new fixtures are generated by a real JVM. Remaining unwraps are invariants (interpreter stack discipline, thread attach), guarded lookups, or documented gaps (lenient calendar normalization, ClassFormatError plumbing). * Inline the IOException conversion at each I/O call site * Return the same Thread object from Thread.currentThread() (dlunch#175) Every attached thread now owns its java/lang/Thread instance: attach takes the instance for threads started via Thread.start (so currentThread() inside run() is the started Thread object) and creates one otherwise (bootstrap, external attachers). currentThread() returns the stored instance, and the GC roots it per thread. Also parse unrecognized classfile attributes as an opaque Unknown variant instead of failing — JVMS 4.7.1 requires silently ignoring them, and the anonymous-class fixture carries EnclosingMethod and Signature attributes the parser rejected. Expected output for the fixture is generated by a real JVM. * Add Java primitive wrapper classes (dlunch#176) * Add Java primitive wrapper classes * Use Character digit semantics for numeric parsing * Bump tokio from 1.52.3 to 1.52.4 (dlunch#179) Bumps [tokio](https://github.com/tokio-rs/tokio) from 1.52.3 to 1.52.4. - [Release notes](https://github.com/tokio-rs/tokio/releases) - [Commits](tokio-rs/tokio@tokio-1.52.3...tokio-1.52.4) --- updated-dependencies: - dependency-name: tokio dependency-version: 1.52.4 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * [rustjava-upstream-sync-s1-tracing-cut-1f356ae] docs: record S1 landing (conflicts 2, setProperty descriptor breakage) --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Inseok Lee <git@dlun.ch> Co-authored-by: jun0 <junyoung.choi.a@miraeasset.com>
Summary
Numberand the missing primitive wrapper classes with Java 1.2-compatible APIsIntegerand add primitiveClassobjects used by wrapperTYPEfieldsValidation
cargo fmt --all -- --checkcargo test --workspacecargo clippy --workspace --all-targets -- -D warnings