fix(path): use os.getenv instead of vim.env in PathLib:expand - #296
Merged
Conversation
vim.env's __index is backed by Vimscript's getenv(), which requires Neovim's main/textlock context. PathLib:expand (via PathLib:absolute) is called while processing paths from git subprocess output, which happens inside libuv fast-event callbacks on Neovim 0.10+, throwing an E5560-class error. os.getenv is a plain Lua/C call safe from any context. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Owner
|
Thanks @napisani for catching this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vimscript's getenv() — a call that requires Neovim's main/textlock context.
subprocess output, which runs inside libuv job/process callbacks (fast-event context). On Neovim 0.10+ this throws an E5560-class
error ("Vimscript function must not be called in a lua loop callback") for any path containing a literal $VAR segment.
and a drop-in equivalent for this read-only lookup.