Skip to content

[Model] PinSAGE model with new sampler - #1334

Merged
BarclayII merged 22 commits into
dmlc:masterfrom
BarclayII:pinsage-model
May 14, 2020
Merged

[Model] PinSAGE model with new sampler#1334
BarclayII merged 22 commits into
dmlc:masterfrom
BarclayII:pinsage-model

Conversation

@BarclayII

@BarclayII BarclayII commented Mar 8, 2020

Copy link
Copy Markdown
Collaborator

Description

PinSAGE model on new sampler.

This implements the item-to-item recommendation in the original PinSAGE paper, as opposed to the original coarse implementation I put in this repository.

This implementation should consume a lot less GPU memory and should be a lot faster.

The implementation is still subject to changes as I need to tune the recommendation performance.

TODO

  • Stop using MovieLens and switch to another larger dataset. Tried Nowplaying-rs and got a better result.
  • Tune recommendation performance.

Checklist

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [$CATEGORY] (such as [NN], [Model], [Doc], [Feature]])
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented
  • To the my best knowledge, examples are either not affected by this change,
    or have been fixed to be compatible with this change

@BarclayII

Copy link
Copy Markdown
Collaborator Author

This PR is also related to #514 (since we will have a new implementation) and #1206

@jermainewang

Copy link
Copy Markdown
Member
  • Stop using MovieLens and switch to another larger dataset.

MovieLens has a 10M dataset. Will that suffice your need?

@BarclayII
BarclayII marked this pull request as ready for review March 27, 2020 05:36
@BarclayII BarclayII changed the title [WIP][Model] PinSAGE model with new sampler [Model] PinSAGE model with new sampler Apr 8, 2020
else: # numeric
return torch.FloatTensor(series.values)

class PandasGraphBuilder(object):

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@classicsong Look like this is a good example for CSV data loader too.

Comment thread examples/pytorch/pinsage/process_nowplaying_rs.py Outdated
Comment thread examples/pytorch/pinsage/data_utils.py
@BarclayII

Copy link
Copy Markdown
Collaborator Author

@HuXiangkun Sorry to bug you again. Any other comments?

@BarclayII
BarclayII merged commit 1e84168 into dmlc:master May 14, 2020
@BarclayII
BarclayII deleted the pinsage-model branch May 14, 2020 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants