Update sklearn exporter for scikit-learn 1.10+ - #675
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## mainline #675 +/- ##
============================================
- Coverage 83.93% 83.90% -0.03%
============================================
Files 75 75
Lines 6816 6823 +7
Branches 557 557
============================================
+ Hits 5721 5725 +4
- Misses 1095 1098 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
betatim
reviewed
Jul 27, 2026
Contributor
|
I don't really know the treelite code base so I can't really review this, but it looks reasonable to have a version dependent branch. Do you want to add a regression test to this? |
Collaborator
Author
We already have |
chyunsu3
added a commit
to chyunsu3/treelite
that referenced
this pull request
Aug 25, 2026
* Update sklearn exporter for scikit-learn 1.10+ * Fix version comparsion logic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #674
I validated the changes by running
with both scikit-learn 1.9 and 1.10 (nightly).
cc @betatim