[BUG]: Typo in dwrangler.ts causes WRANGLER_INJECT_MODE to always fallback to inline

[mshibanami]

dmno version

0.0.41

Steps to reproduce

1. Configure WRANGLER_INJECT_MODE: { value: 'secrets' } in your DMNO schema.
2. Set a config item to dynamic: true.
3. Run dwrangler dev.

What is expected?

dwrangler should recognize the secrets injection mode and pass dynamic variables to wrangler using --var flags.

What is actually happening?

dwrangler silently falls back to inline mode. Dynamic variables are not injected as secrets. This happens because DmnoWranglerEnvSchema defines WRANGLER_INJECT_MODE, but dwrangler.ts mistakenly checks for DWRANGLER_INJECT_MODE.

System Info

Any additional comments?

The typo is located in dwrangler.ts:

dmno/packages/platforms/cloudflare/src/dwrangler.ts

Line 145 in 00750ee

const injectMode: 'inline' | 'secrets' = dmnoWranglerSettings.DWRANGLER_INJECT_MODE as any || 'inline';

[philmillman]

thanks for the report will put up a fix shortly

[theoephraim]

@mshibanami - have you checked out varlock? It's the newer evolution of dmno. The varlock cloudflare plugin is now a bit better - as it's able to re-inject secrets back into cloudflare's native secrets system (which was not possible at the time when the dmno plugin was built).

Lots of other really nice improvements too. Happy to help you get migrated over if you're up for it!

[theoephraim]

Ok this should be released shortly. But please migrate over to varlock if you can. Much more active development over there, and you'll be missing out :)

[mshibanami]

@philmillman Thanks for your super fast work!

@theoephraim Oh I thought varlock was intended for a different purpose, so I didn't really look into it. But I'll give it a try if it's an official successor to dmno. Thanks!