Add /resume page, link from nav and hero - #22
Merged
Merged
Conversation
Resume lives as markdown in the pages collection, so updating it is a content edit rather than a code change. Linked from a new "Resume" nav item and as the first button in the hero link row. A fifth nav item overflowed phone screens (the four-item nav was already 19px over at 375px; this made it 91px). Below 520px the nav links now get their own full-width row under the brand, with --nav-h raised to match so anchor scroll offsets stay correct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
/resume: new page fromsrc/content/pages/resume.md, rendered by the existing[...slug].astro+PageLayout. It's markdown, so edits are content changes.siteConfig.socialson purpose so it doesn't also show up in the footer.fileicon for the hero button.Mobile nav fix (included because this PR caused most of it)
A fifth nav link pushed the header off-screen on phones. Measured at 375px: the four-item nav on
mainwas already 19px over the screen edge, and adding Resume made it 91px. Mobile browsers respond by zooming out the whole page.Below 520px, the nav links now go on their own full-width row under the brand.
--nav-hgoes up to 96px at that width soscroll-padding-topand the headingscroll-margin-topstill clear the sticky header.Content notes
Desktop/Jobs/Dominic_Serrano_Resume.pdf, Sep 7) rather thancareer-coach/resume/*.md. The PDF is newer, with a different summary sentence and Experience before Projects.Checks
astro build: 7 pages,/resume/includedvitest: 15/15 passing