fix(runner-win): give the LocalSystem NSSM service gh on PATH + logging (#258) - #259
Merged
Conversation
…ng (#258) An NSSM service runs as LocalSystem, which doesn't inherit the user PATH, so a user-scoped gh (%LOCALAPPDATA%\gh-cli) was invisible — the service -Serve couldn't mint JIT, exited, and NSSM throttled it to Paused (with no captured output). -InstallService now resolves gh's dir at install time and carries it to the service via AppEnvironmentExtra PATH, sets AppStdout/AppStderr to runner/windows/logs/ (gitignored), and polls for Running (warning + log hint if Paused). Instance + template, ASCII/parse verified, tests + gitignore updated. Closes #258. Refs #253 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SATRHKa6mDHDuirhP6QuwL
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The NSSM service runs as LocalSystem, which doesn't inherit the user PATH — so a user-scoped
gh(%LOCALAPPDATA%\gh-cli) was invisible,-Servecouldn't mint JIT, exited, and NSSM throttled the service to Paused (no output captured). Fix:-InstallServiceresolves gh's dir at install time and carries it to the service viaAppEnvironmentExtra PATH, setsAppStdout/AppStderrtorunner/windows/logs/(gitignored), and polls for Running (warns + points at the log if Paused). Instance + template, ASCII/parse verified, tests + gitignore updated.Closes #258. Refs #253