fix: pin pnpm to v10 in Dockerfile to match CI and node:20-alpine - #196
Merged
Conversation
dngrtech
commented
Aug 26, 2026
dngrtech
left a comment
Owner
Author
There was a problem hiding this comment.
PR Review: fix: pin pnpm to v10 in Dockerfile to match CI and node:20-alpine
Strengths
Dockerfile:8— Correct, minimal fix: pins pnpm to the same major version (pnpm@10) that.github/workflows/tests.ymlalready pins viacorepack prepare pnpm@10 --activate, eliminating drift between the CI environment and the Docker build environment.- Pinning avoids the class of bug where
pnpm@latestsilently pulls a newer major that can't read the committedpnpm-lock.yaml(lockfileVersion: '9.0', confirmed compatible with pnpm 10) — alatestpin is exactly the kind of unpinned build input that causes "works in CI, breaks in Docker" failures. - Single-line change, tightly scoped to the stated problem, no unrelated edits.
Issues
Critical (Must Fix)
None.
Important (Should Fix)
None.
Minor (Nice to Have)
- No version bump: per
CLAUDE.md, every PR merge should bumpVERSION,docs/user/version.json,docs/user/releases.md, and the README badge together. This is a build-infrastructure fix with no user-facing behavior change, so a changelog entry has low value, but if the repo's convention is applied uniformly it should either get the bump or an explicit exemption noted in the PR description. - Consider also pinning pnpm via a
packageManagerfield infrontend-react/package.json(Corepack's native mechanism) so the version is declared once and enforced automatically wherever Corepack runs, rather than needing to keep the Dockerfile and CI workflow pins in sync by hand. Not blocking — the current approach already achieves consistency, this just centralizes it for future drift-proofing.
Assessment
Ready to merge? Yes
Reasoning: Correct, minimal, low-risk fix that aligns the Dockerfile with the CI pin already in place; no functional or security concerns.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.