Skip to content

fix: pin pnpm to v10 in Dockerfile to match CI and node:20-alpine - #196

Merged
dngrtech merged 2 commits into
mainfrom
fix/dockerfile-pin-pnpm
Aug 26, 2026
Merged

fix: pin pnpm to v10 in Dockerfile to match CI and node:20-alpine#196
dngrtech merged 2 commits into
mainfrom
fix/dockerfile-pin-pnpm

Conversation

@dngrtech

Copy link
Copy Markdown
Owner

No description provided.

@dngrtech dngrtech left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Review: fix: pin pnpm to v10 in Dockerfile to match CI and node:20-alpine

Strengths

  • Dockerfile:8 — Correct, minimal fix: pins pnpm to the same major version (pnpm@10) that .github/workflows/tests.yml already pins via corepack prepare pnpm@10 --activate, eliminating drift between the CI environment and the Docker build environment.
  • Pinning avoids the class of bug where pnpm@latest silently pulls a newer major that can't read the committed pnpm-lock.yaml (lockfileVersion: '9.0', confirmed compatible with pnpm 10) — a latest pin is exactly the kind of unpinned build input that causes "works in CI, breaks in Docker" failures.
  • Single-line change, tightly scoped to the stated problem, no unrelated edits.

Issues

Critical (Must Fix)

None.

Important (Should Fix)

None.

Minor (Nice to Have)

  • No version bump: per CLAUDE.md, every PR merge should bump VERSION, docs/user/version.json, docs/user/releases.md, and the README badge together. This is a build-infrastructure fix with no user-facing behavior change, so a changelog entry has low value, but if the repo's convention is applied uniformly it should either get the bump or an explicit exemption noted in the PR description.
  • Consider also pinning pnpm via a packageManager field in frontend-react/package.json (Corepack's native mechanism) so the version is declared once and enforced automatically wherever Corepack runs, rather than needing to keep the Dockerfile and CI workflow pins in sync by hand. Not blocking — the current approach already achieves consistency, this just centralizes it for future drift-proofing.

Assessment

Ready to merge? Yes
Reasoning: Correct, minimal, low-risk fix that aligns the Dockerfile with the CI pin already in place; no functional or security concerns.

@dngrtech
dngrtech merged commit e67aab2 into main Aug 26, 2026
@dngrtech
dngrtech deleted the fix/dockerfile-pin-pnpm branch August 26, 2026 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant