Skip to content

Add debug build to lerna#3596

Merged
valadas merged 1 commit intodnnsoftware:developfrom
donker:adddebug
Mar 3, 2020
Merged

Add debug build to lerna#3596
valadas merged 1 commit intodnnsoftware:developfrom
donker:adddebug

Conversation

@donker
Copy link
Copy Markdown
Contributor

@donker donker commented Feb 24, 2020

This was overlooked in the last Lerna/Yarn overhaul. The user must be able to target a local dev site with the Lerna build. It is currently missing as it only runs in production mode.

@donker donker requested a review from mtrutledge February 24, 2020 21:22
@donker donker added this to the 9.5.1 milestone Feb 24, 2020
Copy link
Copy Markdown
Contributor

@david-poindexter david-poindexter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - thanks @donker

Copy link
Copy Markdown
Contributor

@mtrutledge mtrutledge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@mtrutledge
Copy link
Copy Markdown
Contributor

I didnt merge this because the Compress images / build (pull_request) failed with the error 'The repository 'http://security.ubuntu.com/ubuntu cosmic-security Release' does not have a Release file.' @valadas any ideas on that?

@valadas
Copy link
Copy Markdown
Contributor

valadas commented Feb 28, 2020

hmm, yes and no, Azure pipelines is succeeding, the github action to minimize images if failing, I will have to take a look at it, I will take a look when I come back from Orlando... That being said, if there is any rush in merging this, i can force it if needed, just ping me up, all the reset passes.

@bdukes
Copy link
Copy Markdown
Contributor

bdukes commented Feb 28, 2020

@donker it's not letting me rebase this branch on develop, which is needed to fix the GitHub actions failure. Can you do that?

git checkout adddebug
git fetch --all
git rebase upstream/adddebug # assuming your dnnsoftware branch is named upstream
git push --force-with-lease origin adddebug # assuming your donker branch is named origin

@valadas
Copy link
Copy Markdown
Contributor

valadas commented Mar 3, 2020

All green now, merging this.

@valadas valadas merged commit c5cc9ed into dnnsoftware:develop Mar 3, 2020
@donker donker deleted the adddebug branch March 3, 2020 12:21
@valadas valadas modified the milestones: 9.5.1, 9.6.0 Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants