Fixed Invalid Username/EmailAddress When Containing 'onfocus'#3665
Merged
valadas merged 2 commits intodnnsoftware:developfrom Apr 14, 2020
SergeyDryomin:Bugfix/DNN-33796_Invalid_Username_Email_Address_When_Containing_onfocus
Merged
Fixed Invalid Username/EmailAddress When Containing 'onfocus'#3665valadas merged 2 commits intodnnsoftware:developfrom SergeyDryomin:Bugfix/DNN-33796_Invalid_Username_Email_Address_When_Containing_onfocus
valadas merged 2 commits intodnnsoftware:developfrom
SergeyDryomin:Bugfix/DNN-33796_Invalid_Username_Email_Address_When_Containing_onfocus
Conversation
Invalid Username/Email Address When Containing "onfocus"
Contributor
|
@SergeyDryomin please create a proper GitHub issue describing the bug/enhancement in detail. |
bdukes
reviewed
Apr 7, 2020
| new Regex("onerror", RxOptions), | ||
| new Regex("onload", RxOptions), | ||
| new Regex("onfocus", RxOptions), | ||
| new Regex("\bonfocus\b", RxOptions), |
Contributor
There was a problem hiding this comment.
It would seem like we'd want this change for all of the onwhatever expressions, right?
SergeyDryomin
changed the title
david-poindexter
approved these changes
Apr 13, 2020
Contributor
david-poindexter
left a comment
david-poindexter
left a comment
There was a problem hiding this comment.
Looks good to me - thanks @SergeyDryomin 🎉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes "New user registration/creation doesn't allow for email addresses to contain "onfocus" word"
Fixes #3666
Summary
Solution to replace RegEx
fixed
Not UT's for open source