Fix weird shorting in site settings PB heading#3780
Fix weird shorting in site settings PB heading#3780valadas merged 2 commits intodnnsoftware:developfrom
Conversation
|
@bdukes @valadas @david-poindexter please have a look |
david-poindexter
left a comment
david-poindexter
left a comment
There was a problem hiding this comment.
@gbulicanu thank you for the contribution. However, this is not the correct fix for this issue. This fix would only override the behavior for the SiteSettings module specifically. This is actually a global issue that needs to be resolved in Dnn.React.Common > PersonaBarPageHeader. That way it will be fixed in all PB modules.
|
@gbulicanu for quick reference, the character default limit is set HERE if you want to update this PR accordingly. |
will do that way, I know that that option might be better solution, but started PR to get to this discussion. |
valadas
left a comment
valadas
left a comment
There was a problem hiding this comment.
Awesome, thanks @gbulicanu looks good to me.
4 participants
Fixes #3690
Summary
Extend PersonaBarPageHeader component titleCharLimit yo better suit localized versions, 50 seems to be better here than component default 20.