Skip to content

StyleCop#3802

Merged
mitchelsellers merged 2 commits intodnnsoftware:developfrom
bdukes:style-cop
Jun 5, 2020
Merged

StyleCop#3802
mitchelsellers merged 2 commits intodnnsoftware:developfrom
bdukes:style-cop

Conversation

@bdukes
Copy link
Copy Markdown
Contributor

@bdukes bdukes commented May 29, 2020

Add StyleCop.Analyzers NuGet package to all projects, reference a shared stylecop.config file in projects

@mitchelsellers mitchelsellers added this to the 9.6.2 milestone May 29, 2020
david-poindexter
david-poindexter approved these changes May 29, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@david-poindexter david-poindexter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bdukes

@david-poindexter
Copy link
Copy Markdown
Contributor

david-poindexter commented May 29, 2020

/azp run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented May 29, 2020

No pipelines are associated with this pull request.

valadas
valadas requested changes May 31, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@valadas valadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like a couple of projects are missing the reference to the stylecop.json

See build errors here:
image

@bdukes
Add stylecop.config
d5985be 
(cherry picked from commit 810d73a)
@bdukes
Copy link
Copy Markdown
Contributor Author

bdukes commented Jun 1, 2020

Whoops, looks like stylecop.json was in the .gitignore and wasn't included at all in the commit. Weird how only 4 projects failed. New build running now, hopefully it'll be all green.

@bdukes
Add StyleCop.Analyzers
4c355bf 
(cherry picked from commit 096f19c)

# Conflicts:
#	DNN Platform/DotNetNuke.Web.Deprecated/packages.config
#	DNN Platform/DotNetNuke.Web.Mvc/packages.config
#	DNN Platform/DotNetNuke.Web.Razor/packages.config
#	DNN Platform/DotNetNuke.Web/packages.config
#	DNN Platform/Library/packages.config
#	DNN Platform/Tests/DotNetNuke.Tests.Web.Mvc/packages.config
#	DNN Platform/Website/packages.config
@bdukes
Copy link
Copy Markdown
Contributor Author

bdukes commented Jun 1, 2020

It looks like a couple of projects are missing the reference to the stylecop.json

See build errors here:
image

@valadas it's 🟢 now

@bdukes bdukes requested a review from valadas June 1, 2020 15:49
@bdukes
Copy link
Copy Markdown
Contributor Author

bdukes commented Jun 1, 2020

We now have 239,659 warnings vs. 428 warnings from the previous build 😬

We may need to walk through some configuration and auto-fixes.

@valadas
Copy link
Copy Markdown
Contributor

valadas commented Jun 5, 2020

Nice, it builds :) Now do we merge it now or you have other changes to make as per your previous comment @bdukes ?

@bdukes
Copy link
Copy Markdown
Contributor Author

bdukes commented Jun 5, 2020

I would say we merge it now, and tackle other issues separately

@mitchelsellers
Copy link
Copy Markdown
Contributor

mitchelsellers commented Jun 5, 2020

Works for me as well. Merging, and this will work well with the inclusion of SonarCube as well.

@mitchelsellers mitchelsellers merged commit 76fc4be into dnnsoftware:develop Jun 5, 2020
@bdukes bdukes mentioned this pull request Jun 5, 2020
Merged
@bdukes bdukes deleted the style-cop branch July 28, 2020 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@david-poindexter david-poindexter david-poindexter approved these changes

@mitchelsellers mitchelsellers mitchelsellers approved these changes

@valadas valadas valadas approved these changes

Assignees

No one assigned

Labels

Type: Build/Release Type: Maintenance

Projects

None yet

Milestone

9.6.2

Development

Successfully merging this pull request may close these issues.

4 participants

@bdukes @david-poindexter @valadas @mitchelsellers