StyleCop fixes by bdukes · Pull Request #3831 · dnnsoftware/Dnn.Platform

bdukes · 2020-06-09T22:03:45Z

Most of the auto-fixes

valadas · 2020-06-09T22:19:09Z

Odd, there are random charaters missing here and there:

bdukes · 2020-06-09T23:40:52Z

😦 Looks like these auto-fixes aren't without their bugs… Ugh.

bdukes · 2020-06-10T19:58:24Z

I was able to find a way to automate applying most of the fixes. It's not 100%, and a few of the documentation fixes are weird (e.g. SA1642). I'm going to try another round of automatically applying fixes and pinpoint the ones that cause compile problems.

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1000.md

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1001.md

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1002.md

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1003.md

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1004.md

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1005.md

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1008.md

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1009.md

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1010.md

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1011.md

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1012.md

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1013.md

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1014.md

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1015.md

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1019.md

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1024.md

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1025.md

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1026.md

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1027.md

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1028.md

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1100.md

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1106.md

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1107.md

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1516.md

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1518.md

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1519.md

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1520.md

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1610.md

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1615.md

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1617.md

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1623.md

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1626.md

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1629.md

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1633.md

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1642.md

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1643.md

bdukes · 2020-06-12T20:17:58Z

Alright, build succeeded. 55,464 warnings instead of 194,461 warnings on the previous build. Also shaved 7 minutes off the build.

I'm going to manually apply/fix some of the auto-fixes that caused build errors. Y'all can merge this now and I'll push those changes as a separate PR, or I can push to this PR if nothing's moved on it before I'm done.

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1200.md

valadas

I did a "spot check", it looks fine to me and I resolved 2 small conflicts. Looks good to me

valadas · 2020-06-13T07:31:23Z

Hmm, we have a new error, not sure if caused by my fixing of conflicts, they where pretty basic to resolve...

bdukes · 2020-06-13T13:55:08Z

Thanks @valadas! I've just pushed a change which should fix it. One side moved the using statements inside the namespace and the other side added a new using statement, and the resolution left out the new using statement.

bdukes · 2020-06-13T13:55:40Z

Also, with the SA1200 change, we're down to 36,883 warnings.

valadas · 2020-06-15T06:36:11Z

Oh, sorry, my bad :)

/azp run

valadas · 2020-06-15T06:36:34Z

/azp run

azure-pipelines · 2020-06-15T06:36:40Z

No pipelines are associated with this pull request.

valadas · 2020-06-15T07:48:09Z

Cool, it builds :) Can we get a second approver @dnnsoftware/approvers

mitchelsellers · 2020-06-15T15:10:10Z

Just confirming before I do this, we are good to merge this right? @valadas @bdukes

bdukes · 2020-06-15T15:24:04Z

Yessir

bdukes added the Type: Maintenance label Jun 9, 2020

bdukes added this to the 9.6.2 milestone Jun 9, 2020

bdukes force-pushed the style-cop-fixes branch from 9b58541 to fbc7a69 Compare June 10, 2020 19:21

bdukes changed the title ~~Style cop fixes (spacing)~~ StyleCop fixes Jun 10, 2020

bdukes added 23 commits June 11, 2020 20:59

SA1000

57dfe29

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1000.md

SA1001

91472fb

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1001.md

SA1002

3c37ecd

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1002.md

SA1003

240f674

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1003.md

SA1004

5847bab

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1004.md

SA1005

64eebbf

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1005.md

SA1008

4210ee2

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1008.md

SA1009

0898602

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1009.md

SA1010

c2c10c2

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1010.md

SA1011

b6324db

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1011.md

SA1012

e86de22

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1012.md

SA1013

80bcf7b

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1013.md

SA1014

effc7ef

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1014.md

SA1015

8359854

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1015.md

SA1019

637d44b

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1019.md

SA1024

d50083a

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1024.md

SA1025

88b4a42

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1025.md

SA1026

10abd6c

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1026.md

SA1027

fec3914

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1027.md

SA1028

3a54814

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1028.md

SA1100

3d3e911

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1100.md

SA1106

da86afc

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1106.md

SA1107

fd0319d

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1107.md

bdukes added 13 commits June 12, 2020 11:44

SA1516

4cd0fa2

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1516.md

SA1518

4cf55d4

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1518.md

SA1519

e4517f2

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1519.md

SA1520

a347b86

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1520.md

SA1610

1201d8b

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1610.md

SA1615

d6f5eba

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1615.md

SA1617

1cace60

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1617.md

SA1623

4bedbe2

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1623.md

SA1626

955db35

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1626.md

SA1629

878c5d1

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1629.md

SA1633

8c96fb9

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1633.md

SA1642

c91349e

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1642.md

SA1643

36e9f43

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1643.md

bdukes force-pushed the style-cop-fixes branch from fbc7a69 to 36e9f43 Compare June 12, 2020 19:07

SA1200

084c087

See https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/1.1.118/documentation/SA1200.md

valadas approved these changes Jun 13, 2020

View reviewed changes

Merge branch 'develop' into style-cop-fixes

1836150

bdukes force-pushed the style-cop-fixes branch from 8323c49 to 1836150 Compare June 13, 2020 13:54

mitchelsellers approved these changes Jun 15, 2020

View reviewed changes

mitchelsellers merged commit cc61549 into dnnsoftware:develop Jun 15, 2020

Uh oh!

Conversation

bdukes commented Jun 9, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

valadas commented Jun 9, 2020

Uh oh!

bdukes commented Jun 9, 2020

Uh oh!

bdukes commented Jun 10, 2020

Uh oh!

bdukes commented Jun 12, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

valadas left a comment

Choose a reason for hiding this comment

Uh oh!

valadas commented Jun 13, 2020

Uh oh!

bdukes commented Jun 13, 2020

Uh oh!

bdukes commented Jun 13, 2020

Uh oh!

valadas commented Jun 15, 2020

Uh oh!

valadas commented Jun 15, 2020

Uh oh!

azure-pipelines bot commented Jun 15, 2020

Uh oh!

valadas commented Jun 15, 2020

Uh oh!

mitchelsellers commented Jun 15, 2020

Uh oh!

bdukes commented Jun 15, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

bdukes commented Jun 9, 2020 •

edited

Loading

bdukes commented Jun 12, 2020 •

edited

Loading