Merged
Conversation
Clean up "Unmerged change from project"
Per StyleCop
Per StyleCop
Per StyleCop
donker
approved these changes
Jun 17, 2020
valadas
added a commit
to valadas/Dnn.Platform
that referenced
this pull request
Jul 27, 2020
Closes dnnsoftware#3906 Apparently some files where deleted as part of dnnsoftware#3843 This PR brings those files back and also fixes stylecop warnings. Some class names had to be changed both for clarity and to respect stylecop rule that the file name should match the class name. Because of that change, the dnn manifest was also changed so it all works with the new names.
david-poindexter
pushed a commit
that referenced
this pull request
Jul 27, 2020
* Resolves 9.6.2 logging issue. Closes #3906 Apparently some files where deleted as part of #3843 This PR brings those files back and also fixes stylecop warnings. Some class names had to be changed both for clarity and to respect stylecop rule that the file name should match the class name. Because of that change, the dnn manifest was also changed so it all works with the new names. * fixes one missed ref in manifest
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's the gift that keeps on giving.