Fix to email template retrieval for messaging#3846
Merged
mitchelsellers merged 1 commit intodnnsoftware:developfrom Jun 17, 2020
Merged
Fix to email template retrieval for messaging#3846mitchelsellers merged 1 commit intodnnsoftware:developfrom
mitchelsellers merged 1 commit intodnnsoftware:developfrom
Conversation
bdukes
approved these changes
Jun 17, 2020
mitchelsellers
approved these changes
Jun 17, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The messaging dispatch scheduled task gathers and sends emails to users. However, it relies on GetString from localization without passing portalSettings. This means that portal overrides of the resx file (GlobalResources) are ignored. This PR fixes that.