Skip to content

Include CSS and JS CDF methods in the Dnn helper for Razor#3891

Merged
valadas merged 4 commits intodnnsoftware:developfrom
donker:razorcdf
Jul 7, 2020
Merged

Include CSS and JS CDF methods in the Dnn helper for Razor#3891
valadas merged 4 commits intodnnsoftware:developfrom
donker:razorcdf

Conversation

@donker
Copy link
Copy Markdown
Contributor

@donker donker commented Jul 5, 2020

I find myself including helper methods in all of my projects to do this. We have a control in web forms, but we don't have anything equivalent for MVC modules. This PR addresses that.

@donker donker added this to the 9.7.0 milestone Jul 5, 2020
@bdukes
Copy link
Copy Markdown
Contributor

bdukes commented Jul 6, 2020

    Helpers\DnnHelper.cs(20,26): error CS0234: The type or namespace name 'Client' does not exist in the namespace 'DotNetNuke.Web' (are you missing an assembly reference?) [D:\a\1\s\DNN Platform\DotNetNuke.Web.Mvc\DotNetNuke.Web.Mvc.csproj]
    Helpers\DnnHelper.cs(134,52): error CS0246: The type or namespace name 'FileOrder' could not be found (are you missing a using directive or an assembly reference?) [D:\a\1\s\DNN Platform\DotNetNuke.Web.Mvc\DotNetNuke.Web.Mvc.csproj]

Copy link
Copy Markdown
Contributor

@bdukes bdukes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add helpers for JS libraries, also.

Comment thread DNN Platform/DotNetNuke.Web.Mvc/Helpers/DnnHelper.cs Outdated
Comment thread DNN Platform/DotNetNuke.Web.Mvc/Helpers/DnnHelper.cs
donker and others added 2 commits July 6, 2020 20:08
Co-authored-by: Brian Dukes <bdukes@engagesoftware.com>
Co-authored-by: Brian Dukes <bdukes@engagesoftware.com>
Copy link
Copy Markdown
Contributor

@valadas valadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@valadas valadas merged commit 9009378 into dnnsoftware:develop Jul 7, 2020
@donker donker deleted the razorcdf branch July 10, 2020 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants