Visualizer not able to change settings in shared pages#3917
Merged
bdukes merged 3 commits intodnnsoftware:developfrom Jul 20, 2020
Merged
Visualizer not able to change settings in shared pages#3917bdukes merged 3 commits intodnnsoftware:developfrom
bdukes merged 3 commits intodnnsoftware:developfrom
Conversation
mitchelsellers
approved these changes
Jul 17, 2020
bdukes
force-pushed
the
bugfix/DNN-33330
branch
2 times, most recently
from
e19076d to
cbd372f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3911
Fix summary: A differentiable exception is thrown now so that the message of the exception can be shown if the exception data includes "IsModuleDoesNotBelongToPage" bool; the exception type is not changed to not cause any regressions (some places might depend on that specific exception type). There is also another PR made (on an Engage repo) which checks the thrown exception in SettingsController.cs
Demo: https://drive.google.com/file/d/10QAWw7IES9l3lY_nc-88r0LVsOGWx-ut/view?usp=sharing