Add List-Services command to Prompt#3932
Merged
david-poindexter merged 6 commits intodnnsoftware:developfrom Jul 27, 2020
Merged
Add List-Services command to Prompt#3932david-poindexter merged 6 commits intodnnsoftware:developfrom
david-poindexter merged 6 commits intodnnsoftware:developfrom
Conversation
It doesn't need to implement IDnnStartup, it can just configure the service provider and be done. This also allows us to stop ignoring other IDnnStartup instances in the DotNetNuke.Web project, were they to be created later.
This ensures that it's called at the right time relative to all other DI configuration.
bdukes
changed the title
mitchelsellers
approved these changes
Jul 26, 2020
Contributor
mitchelsellers
left a comment
mitchelsellers
left a comment
There was a problem hiding this comment.
I tested this locally, this is an EPIC developer feature for sure!
Per other commentary, I'm ok with this being in 9.6.3, but flag as a feature
david-poindexter
approved these changes
Jul 27, 2020
Contributor
david-poindexter
left a comment
david-poindexter
left a comment
There was a problem hiding this comment.
Wow @bdukes - this is GREAT!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR relies upon #3920.
Fixes #3931.