Skip to content

Improves GitVersion speed#4016

Merged
david-poindexter merged 3 commits intodnnsoftware:developfrom
valadas:gitversion-perf
Aug 26, 2020
Merged

Improves GitVersion speed#4016
david-poindexter merged 3 commits intodnnsoftware:developfrom
valadas:gitversion-perf

Conversation

@valadas
Copy link
Copy Markdown
Contributor

@valadas valadas commented Aug 26, 2020

Sets the maximum GitVersion lookup date to january 1st 2020 thus speeding up GitVersion calculations a lot. This means GitVersion will only look at commits from this year instead of well all the project history to find tags and read commit messages, etc.

Ignores commits before 2020 for GitVersion calculations, thus speeding up builds.
@valadas valadas added this to the 9.7.1 milestone Aug 26, 2020
Copy link
Copy Markdown
Contributor

@mitchelsellers mitchelsellers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - We should make a note somewhere that this is a tasks that should be updated once a year? It appears that we don't have any real way around limiting by date though, so this is a great solution

Comment thread gitversion.yml Outdated
Copy link
Copy Markdown
Contributor

@david-poindexter david-poindexter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be a huge help in build times - thanks @valadas 🎉

Comment thread gitversion.yml Outdated
Changing date to `2020-01-01` instead of `2019-01-01`
@valadas
Copy link
Copy Markdown
Contributor Author

valadas commented Aug 26, 2020

Ok, I played a bit with different values and it looks like there is some unavoidable overhead no matter what value, but will it still improves the very very long times though. What's odd is running just gitversion is almost instant but in the build script (Cake) it never really get's under a minute... When I get more time maybe I can take a look at upgrading either cake or GitVersion

@david-poindexter david-poindexter merged commit f11150e into dnnsoftware:develop Aug 26, 2020
@valadas valadas deleted the gitversion-perf branch April 14, 2022 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants