Implement clickable column headers on the users table#4032
Merged
valadas merged 1 commit intodnnsoftware:developfrom Sep 5, 2020
Merged
Implement clickable column headers on the users table#4032valadas merged 1 commit intodnnsoftware:developfrom
valadas merged 1 commit intodnnsoftware:developfrom
Conversation
mitchelsellers
approved these changes
Sep 2, 2020
Contributor
Contributor
Author
valadas
approved these changes
Sep 2, 2020
Contributor
valadas
left a comment
valadas
left a comment
There was a problem hiding this comment.
Looks good to me and works great. Maybe as a future improvement we could add some sort indicators...
Contributor
|
I am feeling pretty save getting this into 9.7.2 anyone against ? |
Contributor
|
I am good with it
…On Fri, Sep 4, 2020 at 4:41 PM Daniel Valadas ***@***.***> wrote:
I am feeling pretty save getting this into 9.7.2 anyone against ?
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#4032 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAQIT7XXKMJ4KDJYLCYMFYLSEFUH7ANCNFSM4QSGNTMQ>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows the user to click on the three column headers to sort by them (DisplayName, Email and Joined Date). Clicking again will invert the sort order.