Fixed an issue with user management in portal groups#4041
Merged
david-poindexter merged 7 commits intodnnsoftware:developfrom Sep 3, 2020
Merged
Fixed an issue with user management in portal groups#4041david-poindexter merged 7 commits intodnnsoftware:developfrom
david-poindexter merged 7 commits intodnnsoftware:developfrom
Conversation
Contributor
valadas
commented
Sep 3, 2020
valadas
commented
- Fixed an issue with user management in portal groups
- Fixed many of the build warnings, there are a couple left about IPortalSettings vs PortalSettings which I did not fix because I think the correct solution would involve modifying other components so they can take IPortalSettings instead of PortalSettings and well, lack of time on that...
bdukes
approved these changes
Sep 3, 2020
Corrected spelling of length. Co-authored-by: Brian Dukes <bdukes@engagesoftware.com>
Corrected spelling of deleted. Co-authored-by: Brian Dukes <bdukes@engagesoftware.com>
Corrected spelling of indicating. Co-authored-by: Brian Dukes <bdukes@engagesoftware.com>
Corrected spelling of its. Co-authored-by: Brian Dukes <bdukes@engagesoftware.com>
Corrected spelling of its. Co-authored-by: Brian Dukes <bdukes@engagesoftware.com>
david-poindexter
approved these changes
Sep 3, 2020
Contributor
david-poindexter
left a comment
david-poindexter
left a comment
There was a problem hiding this comment.
Thanks @valadas!
Contributor
Author
|
Thanks for the typo fixes 👍 |
mitchelsellers
approved these changes
Sep 3, 2020
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.