Fix Simple Web Farm Caching Provider not getting packaged#7177
Merged
mitchelsellers merged 2 commits intodnnsoftware:developfrom Apr 1, 2026
Merged
Conversation
… SDK. + Restore the path to match the one in the .dnn manifest file. + By default SDK projects add the target framework to the output path. + Because the dlls where no longer there, it appears that the packaging was somehow silently skipped.
donker
approved these changes
Apr 1, 2026
mitchelsellers
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #7170.
There were two issues. The first is that the project was using
<Target Name="AfterBuild" DependsOnTargets="Package" />in order to run thePackagetask after theBuildtask. However, this no longer works in SDK-style projects (because these auto-generate a differentAfterBuildtask). The correct way to add a task into the pipeline is to useBeforeTargets="Build", instead of relying on a conventional target name. Somehow that had been fixed for all other projects but got missed in this one.The second issue that, once the project was actually trying to package itself (or to copy DLLs to the website output during a Debug build), it was failing to find the DLLs, because, again, SDK-style projects use a different default output path, and so that needed to be overridden.
Thanks @dimarobert for tracking this down and starting the fix!