fix(service): wrap Windows execution with cmd /c#9
Merged
Conversation
…es from working dir
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…es from working dirJava's ProcessBuilder on Windows resolves command names against PATH
only — it does not search the working directory the way Unix shells
do. So even after CommandRunner.adaptForOs() translated "./main"
into "main.exe", Windows couldn't find the executable that gcc had
just produced in the per-submission temp working dir, and every run
failed with
Cannot run program "main.exe" (in directory "...").Fix: on Windows, prefix the execute() command with "cmd" "/c" so the
Windows shell handles resolution. Linux/macOS path unchanged.
Verified locally with the design-doc-standard runCommand "./main" and
Emre's six fixtures:
Lets us ship examples/configurations/c_standard.json with the portable
"./main" rather than a Windows-only workaround.