This repository was archived by the owner on Dec 19, 2022. It is now read-only.
feat: Support _disableContribution - #49
Merged
Merged
Conversation
yufeih
approved these changes
Apr 8, 2022
yufeih
left a comment
yufeih
left a comment
Contributor
There was a problem hiding this comment.
Thanks! Ideally we should have test for this bug the test infra hasn't been setup just yet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It hides the star and the edit source buttons if the
_disableContributionglobal metadata is set.However, I have not been able to find a way to remove the metadata of the pages with the
original_content_git_urlandgitcommit. If I understand correctly this is handled bydocfxand not the template? If so, I guess this pull request is complete