This repository was archived by the owner on Jan 21, 2020. It is now read-only.
xAdd support for InitScriptTemplateURL to vanilla flavor plugin#619
Merged
chungers merged 1 commit intodocker-archive:masterfrom Jul 6, 2017
Merged
xAdd support for InitScriptTemplateURL to vanilla flavor plugin#619chungers merged 1 commit intodocker-archive:masterfrom
InitScriptTemplateURL to vanilla flavor plugin#619chungers merged 1 commit intodocker-archive:masterfrom
Conversation
Adds the same support that is in the swarm flavor plugin; the main difference is that this plugin does not need any dynamic content (like a join token). Closes docker-archive#616 Signed-off-by: Steven Kaufer <kaufer@us.ibm.com>
Codecov Report
@@ Coverage Diff @@
## master #619 +/- ##
=======================================
Coverage 46.84% 46.84%
=======================================
Files 87 87
Lines 6197 6197
=======================================
Hits 2903 2903
Misses 3000 3000
Partials 294 294Continue to review full report at Codecov.
|
chungers
approved these changes
Jul 6, 2017
Contributor
chungers
left a comment
chungers
left a comment
There was a problem hiding this comment.
LGTM. Thanks for adding the tests!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the same support that is in the swarm flavor plugin; the main difference is that this plugin does not need any dynamic content (like a join token).
Closes #616
Signed-off-by: Steven Kaufer kaufer@us.ibm.com