This repository was archived by the owner on Oct 13, 2023. It is now read-only.
[17.09] Don't abort when setting may_detach_mounts#317
Merged
andrewhsu merged 1 commit intodocker-archive:17.09from Nov 30, 2017
Merged
Conversation
83c2152 sets the kernel param for fs.may_detach_mounts, but this is not neccessary for the daemon to operate. Instead of erroring out (and thus aborting startup) just log the error. Signed-off-by: Brian Goff <cpuguy83@gmail.com> (cherry picked from commit c6a2044) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
docker-jenkins
pushed a commit
that referenced
this pull request
Apr 4, 2019
bump docker app commit to baf0b24 Upstream-commit: adb3981 Component: packaging
docker-jenkins
pushed a commit
that referenced
this pull request
Aug 9, 2019
[19.03 backport] Fix regression in handling of NotFound err during startup ENGCORE-929 Upstream-commit: 29fe4e58c6c9a45acdf141476b418106fbeda284 Component: engine
silvin-lubecki
pushed a commit
to silvin-lubecki/docker-ce
that referenced
this pull request
Feb 3, 2020
…or_linux_126_dont_abort [17.09] Don't abort when setting may_detach_mounts
akrasnov-drv
pushed a commit
to drivenets/docker-ce
that referenced
this pull request
Apr 23, 2023
bump docker app commit to baf0b24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
back port of moby/moby#35172 for 17.09
(cherry picked from commit c6a2044)
83c2152 sets the kernel param for
fs.may_detach_mounts, but this is not neccessary for the daemon to
operate. Instead of erroring out (and thus aborting startup) just log
the error.
ping @cpuguy83 PTAL