This repository was archived by the owner on Oct 13, 2023. It is now read-only.
[17.09] Restore error type in FindNetwork#331
Merged
andrewhsu merged 1 commit intodocker-archive:17.09from Nov 30, 2017
Merged
Conversation
The error type libnetwork.ErrNoSuchNetwork is used in the controller to retry the network creation as a managed network though the manager. The change of the type was breaking the logic causing the network to not being created anymore so that no new container on that network was able to be launched Added unit test Signed-off-by: Flavio Crisciani <flavio.crisciani@docker.com> (cherry picked from commit 51cea0a) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Member
Author
|
ping @fcrisciani @cpuguy83 PTAL if it looks good; also if we need to include moby/moby@e52001c or not |
|
LGTM |
docker-jenkins
pushed a commit
that referenced
this pull request
Aug 22, 2019
[19.03 backport] Cherry-picking build fixes Upstream-commit: ed20165a37b40ff1cfbe55e218344c5e89f30ee2 Component: engine
silvin-lubecki
pushed a commit
to silvin-lubecki/docker-ce
that referenced
this pull request
Feb 3, 2020
…ix-net-not-found [17.09] Restore error type in FindNetwork
docker-jenkins
pushed a commit
that referenced
this pull request
Jul 21, 2020
docker-ce-cli lacks dependency to groupadd Upstream-commit: c3ff588 Component: packaging
akrasnov-drv
pushed a commit
to drivenets/docker-ce
that referenced
this pull request
Apr 23, 2023
docker-ce-cli lacks dependency to groupadd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of moby/moby#35634 (moby/moby@51cea0a) for 17.09
Conflicts in:
Due to moby/moby@e52001c not being included in 17.09
I fixed the conflicts in
components/engine/daemon/network.goby moving the error fix fromFindNetwork()toGetNetworkByID()The error type libnetwork.ErrNoSuchNetwork is used in the controller
to retry the network creation as a managed network though the manager.
The change of the type was breaking the logic causing the network to
not being created anymore so that no new container on that network
was able to be launched
Added unit test
Signed-off-by: Flavio Crisciani flavio.crisciani@docker.com