This repository was archived by the owner on Oct 13, 2023. It is now read-only.
[17.12] Defaults Makefile VERSION variable to 0.0.0-dev#340
Merged
andrewhsu merged 1 commit intodocker-archive:17.12from Dec 11, 2017
Merged
Conversation
When building we should default to a dummy version unless otherwise specified so we don't get ourselves confused over what is official and what is not. Signed-off-by: Eli Uriegas <eli.uriegas@docker.com> (cherry picked from commit ffcd040) Signed-off-by: Eli Uriegas <eli.uriegas@docker.com>
Contributor
|
Without this patch, version number was not displayed with static builds: With this patch, version number is displayed: |
docker-jenkins
pushed a commit
that referenced
this pull request
Sep 23, 2019
[19.03 backport] bump google.golang.org/grpc v1.23.0 (CVE-2019-9512, CVE-2019-9514, CVE-2019-9515) Upstream-commit: c27f11fa2e1081b3c37d7301b653195018421194 Component: engine
silvin-lubecki
pushed a commit
to silvin-lubecki/docker-ce
that referenced
this pull request
Jan 31, 2020
…sion_packaging [17.12] Defaults Makefile VERSION variable to 0.0.0-dev
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry pick
backport fix from docker/docker-ce-packaging#67
Cherry pick was clean
Original Text
When building we should default to a dummy version unless otherwise
specified so we don't get ourselves confused over what is official and
what is not.
Signed-off-by: Eli Uriegas eli.uriegas@docker.com
(cherry picked from commit ffcd040)
Signed-off-by: Eli Uriegas eli.uriegas@docker.com