Add back windows checksums

[yosifkit]

With the 0.36.0 buildx release, the Windows builds moved to a separate checksums file (with darwin). Most of the change to versions.sh is whitespace.

ref docker/buildx#3978

[tianon]

I don't love how deeply nested this makes everything -- why not capture both, with an echo in between if necessary?

Suggested change

	if checksums="$(_curl "https://github.com/docker/buildx/releases/download/v${buildxVersion}/checksums.txt")"; then
	buildx="$(jq <<<"$checksums" -csR --arg version "$buildxVersion" '
	rtrimstr("\n") | split("\n")
	| map(
	split(" [ *]?"; "")
	checksums+=$'\n' # add back trailing newline to separate the two checksums files
	if checksums+="$(_curl "https://github.com/docker/buildx/releases/download/v${buildxVersion}/checksums-signed.txt")"; then
	if checksums="$(
	set -Eeuo pipefail
	_curl "https://github.com/docker/buildx/releases/download/v${buildxVersion}/checksums.txt"
	echo
	_curl "https://github.com/docker/buildx/releases/download/v${buildxVersion}/checksums-signed.txt"
	)"; then

[yosifkit]

I wanted to make sure that either file not existing would fail so that we don't end up in the partial state again with missing windows urls. Even with set -Eeuo pipefail in the subshell, it doesn't fail early and still runs every command in it.

	if checksums="$(set -x -Eeuo pipefail 
		_curl "https://github.com/docker/buildx/releases/download/v${buildxVersion}/checksums.txt"
		_curl 'http://github.com/something-that-doesnt-exist'
		_curl "https://github.com/docker/buildx/releases/download/v${buildxVersion}/checksums-signed.txt")"; then

++ _curl https://github.com/docker/buildx/releases/download/v0.36.0/checksums.txt
++ exec
++ local code
+++ curl --silent --location -o /dev/fd/42 --write-out '%{http_code}' https://github.com/docker/buildx/releases/download/v0.36.0/checksums.txt
++ code=200
++ case "$code" in
++ return 0
++ _curl http://github.com/something-that-doesnt-exist
++ exec
++ local code
+++ curl --silent --location -o /dev/fd/42 --write-out '%{http_code}' http://github.com/something-that-doesnt-exist
++ code=404
++ case "$code" in
++ return 1
++ _curl https://github.com/docker/buildx/releases/download/v0.36.0/checksums-signed.txt
++ exec
++ local code
+++ curl --silent --location -o /dev/fd/42 --write-out '%{http_code}' https://github.com/docker/buildx/releases/download/v0.36.0/checksums-signed.txt
++ code=200
++ case "$code" in
++ return 0
jq: error (at <stdin>:56): failed to parse os-arch from filename: Found8a75be22ecf40f633fe0a0199be48fa304c0446a0d7fa8a53d7c71b1d0093028

[yosifkit]

I think this would work for a single if.

if checksums="$(_curl "https://github.com/docker/buildx/releases/download/v${buildxVersion}/checksums.txt")"  \
	&& checksums+=$'\n'"$(_curl "https://github.com/docker/buildx/releases/download/v${buildxVersion}/checksums-signed.txt")"; then

Edit: I am unsure how to make nice whitespace with it.

[tianon]

Oh, that's probably the set -e propagation (or rather, lack thereof) inside our function -- I think it needs || return 1 on curl 🤔

$ bash -Eeuo pipefail -xc 'foo="$( echo yes; false; echo no )"; echo "$foo"'
++ echo yes
++ false
++ echo no
+ foo='yes
no'
+ echo 'yes
no'
yes
no

$ bash -Eeuo pipefail -xc 'foo="$( set -Eeuo pipefail; echo yes; false; echo no )"; echo "$foo"'
++ set -Eeuo pipefail
++ echo yes
++ false
+ foo=yes
$ # we fail on `foo=` because the whole line ends up returning `false`

[yosifkit]

$ bash -Eeuo pipefail -xc 'if foo="$( set -Eeuo pipefail; echo yes; false; echo no )"; then echo "$foo"; fi'
++ set -Eeuo pipefail
++ echo yes
++ false
++ echo no
+ foo='yes
no'
+ echo 'yes
no'
yes
no

😢 😭

[tianon]

oof; here's how I'd probably handle the whitespace in your suggested two-parter:

Suggested change

	if checksums="$(_curl "https://github.com/docker/buildx/releases/download/v${buildxVersion}/checksums.txt")"; then
	buildx="$(jq <<<"$checksums" -csR --arg version "$buildxVersion" '
	rtrimstr("\n") | split("\n")
	| map(
	split(" [ *]?"; "")
	checksums+=$'\n' # add back trailing newline to separate the two checksums files
	if checksums+="$(_curl "https://github.com/docker/buildx/releases/download/v${buildxVersion}/checksums-signed.txt")"; then
	if \
	checksums="$(_curl "https://github.com/docker/buildx/releases/download/v${buildxVersion}/checksums.txt")" \
	&& checksums+=$'\n' \
	&& checksums+="$(_curl "https://github.com/docker/buildx/releases/download/v${buildxVersion}/checksums-signed.txt")" \
	; then