getEngineConfigFilePath is only used during test…#1304
Merged
silvin-lubecki merged 1 commit intoAug 22, 2018
Conversation
… so moving it in test files for now. Signed-off-by: Vincent Demeester <vincent@sbr.pm>
Codecov Report
@@ Coverage Diff @@
## master #1304 +/- ##
==========================================
- Coverage 54.76% 54.73% -0.04%
==========================================
Files 292 292
Lines 19285 19267 -18
==========================================
- Hits 10561 10545 -16
+ Misses 8064 8063 -1
+ Partials 660 659 -1 |
dhiltgen
approved these changes
Aug 22, 2018
| } | ||
|
|
||
| // getEngineConfigFilePath will extract the config file location from the engine flags | ||
| func (c baseClient) getEngineConfigFilePath(ctx context.Context, engine containerd.Container) (string, error) { |
Contributor
There was a problem hiding this comment.
Originally this was in use, but in the refactorings it wasn't necessary. My suspicion is we may need this again as things are fleshed out further in the future, but we can pull it back into the main package at that time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… so moving it in test files for now.
Signed-off-by: Vincent Demeester vincent@sbr.pm