[18.09] backport getEngineConfigFilePath is only used during test so moving it in test files for now.#1373
Merged
silvin-lubecki merged 1 commit intoSep 14, 2018
Conversation
… so moving it in test files for now. Signed-off-by: Vincent Demeester <vincent@sbr.pm> (cherry picked from commit 37ca5d6) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Codecov Report
@@ Coverage Diff @@
## 18.09 #1373 +/- ##
==========================================
- Coverage 54.59% 54.55% -0.04%
==========================================
Files 294 294
Lines 19419 19401 -18
==========================================
- Hits 10601 10585 -16
+ Misses 8153 8152 -1
+ Partials 665 664 -1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #1304 for 18.09
cherry-pick was clean; no conflicts